qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races
Date: Wed, 30 Mar 2016 09:32:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0


On 30/03/2016 05:04, tu bo wrote:
> Hi Christian:
> 
> On 03/30/2016 12:31 AM, Christian Borntraeger wrote:
>> On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote:
>>> This works around races that data plane introduces
>>> simply by exiting immediately if we detect
>>> that dataplane is active.
>>>
>>> It's a small but ugly patch, it's only justification
>>> is that it's minimally intrusive, and that it clearly
>>> has no chance to break non data plane users.
>>>
>>> The idea is to rework it all post 2.6.
>>>
>>> Michael S. Tsirkin (2):
>>>    virtio: add aio handler
>>>    virtio-blk: use aio handler for data plane
>>>
>>>   include/hw/virtio/virtio-blk.h  |  2 ++
>>>   include/hw/virtio/virtio.h      |  4 ++++
>>>   hw/block/dataplane/virtio-blk.c | 13 +++++++++++++
>>>   hw/block/virtio-blk.c           | 28 ++++++++++++++++++----------
>>>   hw/virtio/virtio.c              | 36
>>> ++++++++++++++++++++++++++++++++----
>>>   5 files changed, 69 insertions(+), 14 deletions(-)
>>>
>>
>> This also seems to help on my setup.Tu Bo, would be good if you
>> can double check this patch set as well on your setup?
> 
> With qemu master +  [PATCH 0/2] dataplane: fix start/stop races,
> 
> I did NOT see any crash, result is good in my box. thanks

Great, I will send a revised version of Michael's patches with
virtio-scsi too.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]