[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 06/19] qmp-input: Don't consume input when c
Re: [Qemu-devel] [PATCH v14 06/19] qmp-input: Don't consume input when checking has_member
Wed, 13 Apr 2016 10:43:35 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
On 04/13/2016 10:06 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>> Commit e8316d7 mistakenly passed consume=true
> in qmp_input_optional(), right?
>> when checking if
>> an optional member was present, but the mistake was silently
>> ignored since the code happily let us extract a member more than
>> once. Tighten up the input visitor to ensure that a member is
>> consumed exactly once.
 by fixing qmp_input_optional() to pass consume=false
>> To keep the testsuite happy in the case
>> of incomplete input, we have to check whether a member exists
>> in the dictionary before trying to remove it.
> Sure this is only for the testsuite's benefit?
The testsuite was the only client that failed under the tighter
semantics; but the better semantics allow later patches to further
improve the code while guaranteeing that clients remain sane.
> You fix commit e8316d7's incorrect consume=true, don't you? Recommend
> to mention that explicitly.
I thought I did, but I can add wording  along those lines.
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v14 09/19] tests: Add check-qnull, Eric Blake, 2016/04/08
[Qemu-devel] [PATCH v14 06/19] qmp-input: Don't consume input when checking has_member, Eric Blake, 2016/04/08
[Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors, Eric Blake, 2016/04/08
[Qemu-devel] [PATCH v14 11/19] qmp: Support explicit null during visits, Eric Blake, 2016/04/08
[Qemu-devel] [PATCH v14 02/19] qapi-visit: Add visitor.type classification, Eric Blake, 2016/04/08
- Re: [Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling, (continued)