[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression
Date: Wed, 13 Apr 2016 18:48:19 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 13.04.2016 um 17:40 hat Jeff Cody geschrieben:
> On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote:
> > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC
> > over to using blk_pwrite() instead of bdrv_pwrite_sync().  The
> > return value of bdrv_pwrite_sync() was always 0 for success, and
> > create_dynamic_disk() in one instance checked for a non-zero return
> > value to indicate error.  However, blk_pwrite() may return positive
> > values for success.
> > 
> > This fails silently as well, since vpc_create() did not set errp
> > in this failuer case.  Set errp in all instances in vpc_create().
> > 
> > Signed-off-by: Jeff Cody <address@hidden>
> Ping on this series - ideally the whole series for 2.6, but this patch
> in particular is needed for 2.6 to prevent a regression from 2.5 (QEMU
> can no longer create VPC/VHD images without this patch).

The regression was already fixed in commit 40a99aac. With some changes
in the commit message, the rest of this patch is still useful.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]