[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate

From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments
Date: Thu, 28 Apr 2016 16:39:54 +0200

On Thu, Apr 28, 2016 at 4:09 PM, Markus Armbruster <address@hidden> wrote:
> * device_add, qmp_capabilities
>   Not QAPIfied, need everything.

Some related commits from https://github.com/elmarco/qemu/commits/qapi



> * netdev_add, query-qmp-schema
>   Need .args_type because of 'gen': false.
> * client_migrate_info, dump-guest-memory, query-dump, getfd, closefd,
>   add-fd, remove-fd, query-fdsets, migrate-set-capabilities
>   Define .params and/or .help.  Does this make any sense?
> A comment explaining which members need to be set would be nice.
> Have you checked Marc-André's work for overlap?  Cc'ing him.

yeah, it's conflicting with my work. Unfortunately, since I have been
asked to wait since a long time, I am no longer on top of things, nor
what I need to wait for. I have the feeling we really want
qmp_dispatch() in monitor.c:

Eric, I have been waiting for your series to settle for getting back
to qapi, but it keeps growing ;) I hope you are familiar with the work
I did in the branch so we don't duplicate efforts.

Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]