[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster |
Date: |
Sat, 14 May 2016 15:01:12 +0300 |
We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we
will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is
not possible.
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Kevin Wolf <address@hidden>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 97bf870..05beb64 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2412,7 +2412,7 @@ static bool is_zero_cluster(BlockDriverState *bs, int64_t
start)
BlockDriverState *file;
int64_t res = bdrv_get_block_status_above(bs, NULL, start,
s->cluster_sectors, &nr, &file);
- return res >= 0 && ((res & BDRV_BLOCK_ZERO) || !(res & BDRV_BLOCK_DATA));
+ return res >= 0 && (res & BDRV_BLOCK_ZERO);
}
static bool is_zero_cluster_top_locked(BlockDriverState *bs, int64_t start)
--
2.5.0
- [Qemu-devel] [PATCH 0/6] qcow2_co_write_zeroes and related improvements, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 2/6] block: split write_zeroes always, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 3/6] qcow2: simplify logic in qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 6/6] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster,
Denis V. Lunev <=
- [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/14