[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigpr

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] cpus.c: Use pthread_sigmask() rather than sigprocmask()
Date: Tue, 17 May 2016 11:55:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 16/05/2016 19:37, Peter Maydell wrote:
> The only other sigprocmask() uses are in linux-user, apart from
> a couple in net/tap.c, where they're used as part of forking and
> spawning the helper process. I suspect this should be using
> qemu_fork() instead of doing it all by hand, wrongly...

In all fairness those predate qemu_fork(). :)

Your patch also changes a Linux-only function, but it's cleaner to user
pthread_sigmask so I've queued it for the next pull request.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]