[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] qcow2: fix condition in is_zero_cluster

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/3] qcow2: fix condition in is_zero_cluster
Date: Tue, 17 May 2016 11:25:13 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 05/17/2016 10:51 AM, Kevin Wolf wrote:
> From: "Denis V. Lunev" <address@hidden>
> We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we
> will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is
> not possible for images with bdi.unallocated_blocks_are_zero == true.
> For those images where it's false, however, it can happen and we must
> not consider the data zeroed then or we would corrupt the image.
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]