[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aar
Re: [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aarch64
Tue, 31 May 2016 10:31:02 +0100
On 31 May 2016 at 10:04, Vijay Kilari <address@hidden> wrote:
> On Wed, Apr 6, 2016 at 8:31 PM, Vijay Kilari <address@hidden> wrote:
>> On Mon, Apr 4, 2016 at 10:14 PM, Peter Maydell <address@hidden> wrote:
>>> If you want to avoid defining TARGET_PAGE_SIZE to the
>>> lowest-common-denominator 1K, then yes, you'd need to
>>> choose it at runtime. That could be painful to implement.
> The L1 page table size, L1 shift are dependent on TARGET_PAGE_BITS(page size).
> as shown in snippet code below from translate-all.c
Yes, that's why I said "painful to implement" :-)
> How about adding CONFIG_PAGE_SIZE option to configure?.
I don't want this to be a configure option, because QEMU
should just work for everybody. Otherwise we have some QEMU
binaries which silently don't implement the architecture/CPU
that they ought to.