Re: [Qemu-devel] [PATCH 09/17] s390x/pci: introduce S390PCIBusDevice qdev

[Cornelia Huck]

On Tue, 28 Jun 2016 17:49:18 +0300
Marcel Apfelbaum <address@hidden> wrote:

> On 06/24/2016 04:28 PM, Cornelia Huck wrote:
> > From: Yi Min Zhao <address@hidden>

> > +static const TypeInfo s390_pci_device_info = {
> > +    .name = TYPE_S390_PCI_DEVICE,
> > +    .parent = TYPE_DEVICE,
> 
> Hi,
> 
> Here we have the same mismatch.  TYPE_S390_PCI_DEVICE does not derive
> from TYPE_PCI_DEVICE. If I understand correctly the "zpci device"
> is a wrapper to the actual PCI device, maybe the name can reflect it.

TYPE_S390PCI_DEVICE?