|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero |
Date: | Wed, 24 Aug 2016 07:53:37 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 08/23/2016 09:38 PM, Paolo Bonzini wrote:
On 24/08/2016 06:30, address@hidden wrote:ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #44: FILE: util/cutils.c:289: + __asm volatile("vmovdqu -0x80(%1),%0\n\t"Other errors can be ignored, but please use __asm__ __volatile__ here or just __asm__ (I don't think volatile is useful).
I had to add volatile to keep the prefetch in advance of the loop. I suppose I could just add the prefetch to the asm block...
Also, perhaps move this function to its own file since you're rewriting it anyway?
Sure. r~
[Prev in Thread] | Current Thread | [Next in Thread] |