[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero |
Date: |
Wed, 24 Aug 2016 10:59:11 -0400 (EDT) |
----- Original Message -----
> From: "Richard Henderson" <address@hidden>
> To: "Paolo Bonzini" <address@hidden>, address@hidden
> Cc: "peter maydell" <address@hidden>, address@hidden, address@hidden, "vijay
> kilari"
> <address@hidden>
> Sent: Wednesday, August 24, 2016 4:53:37 PM
> Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
>
> On 08/23/2016 09:38 PM, Paolo Bonzini wrote:
> >
> >
> > On 24/08/2016 06:30, address@hidden wrote:
> >> ERROR: Use of volatile is usually wrong: see
> >> Documentation/volatile-considered-harmful.txt
> >> #44: FILE: util/cutils.c:289:
> >> + __asm volatile("vmovdqu -0x80(%1),%0\n\t"
> >
> > Other errors can be ignored, but please use __asm__ __volatile__ here or
> > just __asm__ (I don't think volatile is useful).
>
> I had to add volatile to keep the prefetch in advance of the loop.
> I suppose I could just add the prefetch to the asm block...
Probably easiest, or maybe add barrier() too.
Paolo
- [Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero, (continued)
- [Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero, Richard Henderson, 2016/08/24
- [Qemu-devel] [PATCH 1/7] cutils: Remove SPLAT macro, Richard Henderson, 2016/08/24
- [Qemu-devel] [PATCH 3/7] cutils: Rearrange buffer_is_zero acceleration, Richard Henderson, 2016/08/24
- [Qemu-devel] [PATCH 5/7] cutils: Rewrite x86 buffer zero checking, Richard Henderson, 2016/08/24
- [Qemu-devel] [PATCH 6/7] cutils: Rewrite aarch64 buffer zero checking, Richard Henderson, 2016/08/24
- [Qemu-devel] [PATCH 7/7] cutils: Rewrite ppc buffer zero checking, Richard Henderson, 2016/08/24
- Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero, no-reply, 2016/08/24
- Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero, Dr. David Alan Gilbert, 2016/08/24
Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero, Vijay Kilari, 2016/08/25