Re: [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro

[Felipe Franciosi]

> On 12 Oct 2016, at 18:20, Felipe Franciosi <address@hidden> wrote:
> 
> 
>> On 21 Sep 2016, at 19:15, Eric Blake <address@hidden> wrote:
>> 
>> On 09/21/2016 10:27 AM, Felipe Franciosi wrote:
>>> On GCC versions 3.4 and newer, simply using (void) in front of a
>>> function that has been declared with WUR will no longer suppress a
>>> compilation warning. This commit brings the ignore_value() macro from
>>> GNULIB's ignore_value.h, licensed under the terms of LGPLv2+.
>>> 
>>> See the link below for the original author's comment:
>>> https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05148.html
>>> 
>>> Signed-off-by: Felipe Franciosi <address@hidden>
>>> ---
>>> include/qemu/compiler.h | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>> 
>> Reviewed-by: Eric Blake <address@hidden>
>> 
>> -- 
>> Eric Blake   eblake redhat com    +1-919-301-3266
>> Libvirt virtualization library http://libvirt.org
>> 
> 
> Hi Eric,
> 
> Now that the header and licensing of compiler.h got amended, can we look at 
> this again?
> 
> I think the right solution (at least for the moment) is to stick with my 
> series to fix the build.
> 1/2) We get the ignore_value() macro in.
> 2/2) We ignore the return value of that fwrite().
> 
> As I clarified on my last e-mail in this thread (21/sept), there are many 
> other calls around the replay code which could potentially fail and are all 
> unchecked. We could at least fix the build now and then talk about a separate 
> series to address those, if neccesary.
> 
> Thanks,
> Felipe


Ping?