[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

From: Thomas Huth
Subject: Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol
Date: Sat, 19 Nov 2016 08:32:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 18.11.2016 18:51, Samuel Thibault wrote:
> From: Vincent Bernat <address@hidden>
> Some network equipments are requesting a file using the netascii
> protocol and this is not configurable. Currently, qemu's tftpd only
> supports the octet protocol. This commit makes it accept the netascii
> protocol as well but do not perform the requested transformation (LF ->
> CR,LF) as it would be far more complex.

That sounds somewhat wrong to me. QEMU now seems to support a transfer
mode that is not really implemented. I think you should at least issue a
qemu_log_mask(LOG_UNIMP, "...") call in that case.


PS: As far as I know, this month, PULL requests should be CC:ed to
Stefan, not Peter, since Peter is away.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]