[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qob

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()
Date: Fri, 25 Nov 2016 09:59:04 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 11/24/2016 05:07 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>> address@hidden reported a runtime failure on a
>>> 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd".
>>> Fortunately, we had very few spots that were relying on our
>>> pseudo-printf JSON parsing of int64_t numbers, so it was
>>> easier to just convert callers to stick to safer %lld.
>>> The remaining uses of pseudo-printf handling are more complex;
>>> there are only 3 users in the released codebased, but LOTS of
>>> users in the testsuite (via wrapper functions like qmp()); I
>>> will be posting a followup series that rips out the remaining
>>> uses of dynamic JSON, but it will be 2.9 material, while
>>> these (first three) patches qualify for 2.8.  The fourth patch
>>> is RFC; not intended to be applied now, but shows how I tested
>>> patch 3/4; it will probably reappear in the later 2.9 series.
>> I can take the first three through my tree.
> You mentioned some possible touchups - do you want to make those, or
> have me send a v3?

I made them, and pushed to qapi-next.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]