Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

[Stefan Hajnoczi]

On Thu, Nov 24, 2016 at 12:07:44PM +0100, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
> > address@hidden reported a runtime failure on a
> > 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd".
> > Fortunately, we had very few spots that were relying on our
> > pseudo-printf JSON parsing of int64_t numbers, so it was
> > easier to just convert callers to stick to safer %lld.
> >
> > The remaining uses of pseudo-printf handling are more complex;
> > there are only 3 users in the released codebased, but LOTS of
> > users in the testsuite (via wrapper functions like qmp()); I
> > will be posting a followup series that rips out the remaining
> > uses of dynamic JSON, but it will be 2.9 material, while
> > these (first three) patches qualify for 2.8.  The fourth patch
> > is RFC; not intended to be applied now, but shows how I tested
> > patch 3/4; it will probably reappear in the later 2.9 series.
> 
> I can take the first three through my tree.
> 
> > [*] git log shows the name John, but the particular email that
> > sparked this only stated the non-descript name 'G 3', which
> > makes it a bit hard for me to know which form is preferred
> > when lending credit.
> 
> If someone's capriciousness makes it hard to give credit, not giving it
> can be excused.

git-log(1) shows John Arbuckle <address@hidden>.

Stefan

signature.asc
Description: PGP signature