Re: [Qemu-devel] [PATCH 19/40] char: move to chardev/

[Eric Blake]

On 01/11/2017 11:29 AM, Marc-André Lureau wrote:
> The following commits will split char.c in several files. Let's put them
> in a subdirectory.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qemu-char.c => chardev/char.c | 0

Yay - one less file in the top level :)

>  MAINTAINERS                   | 2 +-
>  Makefile.objs                 | 2 +-
>  chardev/Makefile.objs         | 1 +
>  tests/Makefile.include        | 6 +++---
>  5 files changed, 6 insertions(+), 5 deletions(-)
>  rename qemu-char.c => chardev/char.c (100%)
>  create mode 100644 chardev/Makefile.objs
> 

> +++ b/tests/Makefile.include
> @@ -9,7 +9,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>  check-unit-y = tests/check-qdict$(EXESUF)
>  gcov-files-check-qdict-y = qobject/qdict.c
>  check-unit-y += tests/test-char$(EXESUF)
> -gcov-files-check-qdict-y = qemu-char.c
> +gcov-files-check-qdict-y = chardev/char.c
>  check-unit-y += tests/check-qfloat$(EXESUF)
>  gcov-files-check-qfloat-y = qobject/qfloat.c
>  check-unit-y += tests/check-qint$(EXESUF)
> @@ -489,7 +489,7 @@ tests/check-qjson$(EXESUF): tests/check-qjson.o 
> $(test-util-obj-y)
>  tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o 
> $(test-qom-obj-y)
>  tests/check-qom-proplist$(EXESUF): tests/check-qom-proplist.o 
> $(test-qom-obj-y)
>  
> -tests/test-char$(EXESUF): tests/test-char.o qemu-char.o qemu-timer.o 
> $(test-util-obj-y) $(qtest-obj-y) $(test-block-obj-y)
> +tests/test-char$(EXESUF): tests/test-char.o chardev/char.o qemu-timer.o 
> $(test-util-obj-y) $(qtest-obj-y) $(test-block-obj-y)

Pre-existing so you just kept it, but maybe we should use \ line
wrapping to avoid long lines.

With or without wrapping,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature