[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/40] char: create chardev-obj-y
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 20/40] char: create chardev-obj-y |
Date: |
Thu, 12 Jan 2017 15:47:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/11/2017 11:29 AM, Marc-André Lureau wrote:
> This will help to split char.c in several units without having to
> reference them all everywhere. This is useful in particular for tests.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> @@ -221,7 +222,7 @@ subdir-dtc:dtc/libfdt dtc/tests
> dtc/%:
> mkdir -p $@
>
> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(qom-obj-y)
> $(crypto-aes-obj-$(CONFIG_USER_ONLY))
> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> $(chardev-obj-y) $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY))
Again, splitting long lines with \ would be nice, but not a necessity.
>
> ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
> # Only keep -O and -g cflags
> diff --git a/Makefile.objs b/Makefile.objs
> index cad4c54740..7985d21841 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -51,7 +51,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o
> common-obj-$(CONFIG_LINUX) += fsdev/
>
> common-obj-y += migration/
> -common-obj-y += chardev/ #aio.o
> +common-obj-y += #aio.o
The fact that aio.o is commented is unrelated to your patch, but now
that this line is a comment only, can we delete it?
> common-obj-y += page_cache.o
Or maybe merge it with this line, so it doesn't look quite as odd?
Nothing major, so
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 16/40] char: get rid of CharDriver, (continued)
- [Qemu-devel] [PATCH 17/40] char: rename remaining CharDriver to Chardev, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 18/40] char: remove class kind field, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 21/40] char: make null_chr_write() the default method, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 22/40] char: move null chardev to its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 20/40] char: create chardev-obj-y, Marc-André Lureau, 2017/01/11
- Re: [Qemu-devel] [PATCH 20/40] char: create chardev-obj-y,
Eric Blake <=
- [Qemu-devel] [PATCH 19/40] char: move to chardev/, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 24/40] char: move ringbuf/memory to its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 23/40] char: move mux to its own file, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 26/40] char: remove unused READ_RETRIES, Marc-André Lureau, 2017/01/11
- [Qemu-devel] [PATCH 25/40] char: rename and move to header CHR_READ_BUF_LEN, Marc-André Lureau, 2017/01/11