[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work |
Date: |
Tue, 14 Feb 2017 14:12:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> On 13/02/2017 18:19, Juan Quintela wrote:
>> + qemu_sem_init(&p->init, 0);
>> p->quit = false;
>> + p->c = socket_send_channel_create();
>> + if (!p->c) {
>> + error_report("Error creating a send channel");
>> + exit(0);
>> + }
>> snprintf(thread_name, 15, "multifd_send_%d", i);
>> qemu_thread_create(&p->thread, thread_name, multifd_send_thread, p,
>> QEMU_THREAD_JOINABLE);
>> + qemu_sem_wait(&p->init);
>
> Why do you need p->init here? Could initialization proceed in parallel
> for all the threads?
We need to make sure that the send thread number 2 goes to thread number
2 on destination. Yes, we could do a more complicated algorithm, but we
really care so much about this initialization time?
Later, Juan.
- [Qemu-devel] [PULL 04/12] migration: Create x-multifd-threads parameter, (continued)
- [Qemu-devel] [PULL 04/12] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 06/12] migration: Create multifd migration threads, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 05/12] migration: Create x-multifd-group parameter, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 11/12] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 08/12] migration: Create ram_multifd_page, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 10/12] migration: Really use multiple pages at a time, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 12/12] migration: Test new fd infrastructure, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 09/12] migration: Create thread infrastructure for multifd send side, Juan Quintela, 2017/02/13
Re: [Qemu-devel] [PATCH 00/12] Multifd v4, Peter Maydell, 2017/02/14
Re: [Qemu-devel] [PATCH 00/12] Multifd v4, Paolo Bonzini, 2017/02/14