[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 11/12] migration: Send the fd number which we are
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PULL 11/12] migration: Send the fd number which we are going to use for this page |
Date: |
Tue, 14 Feb 2017 14:16:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> On 13/02/2017 18:19, Juan Quintela wrote:
>> case RAM_SAVE_FLAG_MULTIFD_PAGE:
>> + fd_num = qemu_get_be16(f);
>> + multifd_recv_page(host, fd_num);
>> qemu_get_buffer(f, host, TARGET_PAGE_SIZE);
>> break;
>
> Why do you need RAM_SAVE_FLAG_MULTIFD_PAGE? I understand the
> orchestration of sent pages from a single thread, but could the receive
> threads proceed independently, each reading its own socket? They do not
> even need to tell the central thread "I'm done" (they can do so just by
> exiting, and the central thread does qemu_thread_join when it sees the
> marker for end of live data).
We can send multiple sends in one go, the whole idea was to send the
pages "aligned", and being able to read also in place on destination.
But this showed that we still have bottlenecks on the code that search
for pages :-(
Later, Juan.
- [Qemu-devel] [PATCH 00/12] Multifd v4, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 02/12] migration: Don't create decompression threads if not enabled, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 03/12] migration: Add multifd capability, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 01/12] migration: Test for disabled features on reception, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 04/12] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 06/12] migration: Create multifd migration threads, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 05/12] migration: Create x-multifd-group parameter, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 11/12] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2017/02/13
- [Qemu-devel] [PULL 07/12] migration: Start of multiple fd work, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 08/12] migration: Create ram_multifd_page, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 10/12] migration: Really use multiple pages at a time, Juan Quintela, 2017/02/13
[Qemu-devel] [PULL 12/12] migration: Test new fd infrastructure, Juan Quintela, 2017/02/13