[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap |
Date: |
Fri, 17 Feb 2017 16:27:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:26 AM, Markus Armbruster wrote:
> parse_option_size()'s checking for overflow and trailing crap is
> wrong. Has always been that way. qemu_strtosz() gets it right, so
> use that.
>
> This adds support for size suffixes 'P', 'E', and ignores case for all
> suffixes, not just 'k'.
Yay! Be liberal in what you accept! (I've always been annoyed that '-m
1g' complains, forcing me to us '-m 1G').
Okay, we're at the end of the series, and I've pointed out other
possible improvements. As mentioned elsewhere, it might be nice to add
a 25/24 to match coreutils, which allows 'm' and 'mib' to mean
1024*1024, vs. 'mb' to mean 1000*1000. Right now, all clients of
qemu_strtosz() are stuck to one scale, vs. letting the user choose a
scale by their choice of suffix. But it does not hold up this series if
you don't like the idea.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-qemu-opts.c | 21 +++++++++------------
> util/qemu-option.c | 41 +++++++++++++----------------------------
> 2 files changed, 22 insertions(+), 40 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 09/24] QemuOpts: Fix to reject numbers that overflow uint64_t, (continued)
- [Qemu-devel] [PATCH 13/24] tests/test-cutils: Cover qemu_strtosz() around range limits, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap, Markus Armbruster, 2017/02/14
- Re: [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap,
Eric Blake <=
- [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap, Markus Armbruster, 2017/02/14