[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject i

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject input visitor
Date: Tue, 28 Feb 2017 18:29:14 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 02/26/2017 03:43 PM, Markus Armbruster wrote:
>> The split between tests/test-qobject-input-visitor.c and
>> tests/test-qobject-input-strict.c now makes less sense than ever.  The
>> next commit will take care of that.
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
> If I read Paolo's thread correctly, we were deferring his patches that
> relied on a non-strict visit until 2.10.  And we can re-add non-strict
> via a new constructor, rather than adding back a bool parameter to all
> existing callers, so it doesn't hurt too badly that we are doing this
> now for 2.9 (or a revert always works, if it is justified).


> Reviewed-by: Eric Blake <address@hidden>
>> @@ -276,7 +269,6 @@ static GenericList *qobject_input_next_list(Visitor *v, 
>> GenericList *tail,
>>      return tail->next;
>>  }
>> -
>>  static void qobject_input_start_alternate(Visitor *v, const char *name,
>>                                            GenericAlternate **obj, size_t 
>> size,
>>                                            bool promote_int, Error **errp)
> Spurious hunk?

Yes, will drop.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]