[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5)
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5) |
Date: |
Fri, 7 Apr 2017 19:20:15 -0300 |
static code analyzer complain:
qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a
'nonnull' parameter
closedir(dp);
^~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
qga/commands-posix.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 915df9ed90..fc45102a1e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2124,9 +2124,11 @@ static void transfer_memory_block(GuestMemoryBlock
*mem_blk, bool sys2memblk,
* we think this VM does not support online/offline memory block,
* any other solution?
*/
- if (!dp && errno == ENOENT) {
- result->response =
- GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED;
+ if (!dp) {
+ if (errno == ENOENT) {
+ result->response =
+ GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED;
+ }
goto out1;
}
closedir(dp);
--
2.11.0
- [Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed, Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 1/4] usb-ccid: make ccid_write_data_block() cope with null buffers, Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 2/4] device_tree: fix compiler warnings (clang 5), Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5),
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block, Philippe Mathieu-Daudé, 2017/04/07
- Re: [Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed, Michael Tokarev, 2017/04/23