[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] ipmi: don't try to open a NULL filename

From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH 2/2] ipmi: don't try to open a NULL filename
Date: Tue, 25 Apr 2017 16:06:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/25/2017 03:31 PM, Peter Maydell wrote:
> On 25 April 2017 at 07:51, Cédric Le Goater <address@hidden> wrote:
>> Currenlty, the code relies on the fact that open() handles NULL
>> filenames but that can cause an error with new clang:
>>   hw/core/loader.c:67:15: runtime error: null pointer passed as argument 1,
>>   which is declared to never be null
> This isn't "new clang", incidentally, it's just clang with the
> runtime-static-analysis enabled, which causes warnings to be
> printed at runtime for undefined behaviours. You can enable
> this by passing configure --extra-cflags=-fsanitize=undefined .
> (I have clang 3.8.0 here.)

OK. So I have now reproduced the issue on a f24. That made be 
realize that the IPMI tests check for the arch they are being 
run on and that more changes are required for them to run on 

We can drop patch 1/2. Tell me if you want a resend.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]