[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] ipmi: don't try to open a NULL filename
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] ipmi: don't try to open a NULL filename |
Date: |
Wed, 26 Apr 2017 08:05:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/26/2017 04:42 AM, David Gibson wrote:
> On Tue, Apr 25, 2017 at 08:51:41AM +0200, Cédric Le Goater wrote:
>> Currenlty, the code relies on the fact that open() handles NULL
>> filenames but that can cause an error with new clang:
>>
>> hw/core/loader.c:67:15: runtime error: null pointer passed as argument 1,
>> which is declared to never be null
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>
> Since my ppc-for-2.10 pull request has been held up because of this
> anyway, tather than just apply this on top, I've folded it into your
> earlier patch which caused the bug - that way we won't break bisect.
Yes that is the best option.
Thanks,
C.