[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/14] target/sh4: split ctx->flags into ctx->tb
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 01/14] target/sh4: split ctx->flags into ctx->tbflags and ctx->envflags |
Date: |
Tue, 2 May 2017 21:38:26 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-02 09:16, Philippe Mathieu-Daudé wrote:
> Hi Aurelien,
>
> On 05/01/2017 07:10 PM, Aurelien Jarno wrote:
> > There is a confusion (and not only in the SH4 target) between tb->flags,
> > env->flags and ctx->flags. To avoid it, split ctx->flags into
> > ctx->tbflags and ctx->envflags. ctx->tbflags stays unchanged during the
> > whole TB translation, while ctx->envflags evolves and is kept in sync
> > with env->flags using TCG instructions. ctx->envflags now only contains
> > the part that of env->flags that is contained in the TB state, i.e. the
> > DELAY_SLOT* flags.
>
> I agree with your split, but I'd rather put the 2nd part of your commit
> description as comments in the struct DisasContext declaration, if you mind
> :)
Thanks for the review. I'll do that in the v2, although at some point it
should probably go to some higher level documentation, as it is often a
source of confusion.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 06/14] target/sh4: fix BS_EXCP exit, (continued)
- [Qemu-devel] [PATCH 06/14] target/sh4: fix BS_EXCP exit, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 10/14] target/sh4: optimize gen_write_sr using extract op, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 09/14] target/sh4: optimize gen_store_fpr64, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 02/14] target/sh4: get rid of DELAY_SLOT_CLEARME, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 12/14] target/sh4: implement tas.b using atomic helper, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 13/14] target/sh4: movua.l is an SH4-A only instruction, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 01/14] target/sh4: split ctx->flags into ctx->tbflags and ctx->envflags, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 14/14] target/sh4: trap unaligned accesses, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 07/14] target/sh4: only save flags state at the end of the TB, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 03/14] target/sh4: do not include DELAY_SLOT_TRUE in the TB state, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 04/14] target/sh4: move DELAY_SLOT_TRUE flag into a separate global, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 08/14] target/sh4: fold ctx->bstate = BS_BRANCH into gen_conditional_jump, Aurelien Jarno, 2017/05/01
- [Qemu-devel] [PATCH 11/14] target/sh4: generate fences for SH4, Aurelien Jarno, 2017/05/01