[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag fro
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo |
Date: |
Wed, 3 May 2017 17:35:48 -0300 |
sysbus-fdc and SUNW,fdtwo devices need IRQs to be wired and mmio
to be mapped, and can't be used with -device. Unset
user_creatable on their device classes.
Cc: John Snow <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Marcel Apfelbaum <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: address@hidden
Cc: Thomas Huth <address@hidden>
Acked-by: John Snow <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
Changes v1 -> v2:
* Commit message rewrite only
---
hw/block/fdc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 5c28a0b0ad..2e629b398b 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass,
void *data)
dc->props = sysbus_fdc_properties;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo sysbus_fdc_info = {
@@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass,
void *data)
dc->props = sun4m_fdc_properties;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo sun4m_fdc_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 01/21] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo,
Eduardo Habkost <=
- [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Markus Armbruster, 2017/05/15
[Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03