[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment abo
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true |
Date: |
Wed, 3 May 2017 23:49:35 +0300 |
On Wed, May 03, 2017 at 05:35:47PM -0300, Eduardo Habkost wrote:
> amd-iommu and intel-iommu are really meant to be used with
> -device, so they need user_creatable=true. Remove the FIXME
> comment.
>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Acked-by: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> Changes v1 -> v2:
> * (none)
> ---
> hw/i386/amd_iommu.c | 5 +----
> hw/i386/intel_iommu.c | 5 +----
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index 7b92c8c15a..efcc93cbfd 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void*
> data)
> dc->vmsd = &vmstate_amdvi;
> dc->hotpluggable = false;
> dc_class->realize = amdvi_realize;
> - /*
> - * FIXME: Set only because we are not sure yet if this device
> - * will be outside the q35 sysbus whitelist.
> - */
> + /* Supported by the pc-q35-* machine types */
> dc->user_creatable = true;
> }
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 54187a04a4..327a46cd19 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void
> *data)
> dc->hotpluggable = false;
> x86_class->realize = vtd_realize;
> x86_class->int_remap = vtd_int_remap;
> - /*
> - * FIXME: Set only because we are not sure yet if this device
> - * will be outside the q35 sysbus whitelist.
> - */
> + /* Supported by the pc-q35-* machine types */
> dc->user_creatable = true;
> }
>
> --
> 2.11.0.259.g40922b1
- [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 01/21] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Markus Armbruster, 2017/05/15
[Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/03
[Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/03