[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag |
Date: |
Wed, 17 May 2017 10:39:52 -0300 |
allwinner-ahci needs its IRQ to be connected and mmio to be
mapped (this is done by the alwinner-a10 device realize method),
and won't work with -device. Remove the user_creatable flag from
the device class.
Cc: John Snow <address@hidden>
Cc: address@hidden
Cc: Beniamino Galvani <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Cc: Marcel Apfelbaum <address@hidden>
Acked-by: John Snow <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/ide/ahci.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 2ea1a282ef..f60826d6e0 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1815,11 +1815,6 @@ static void allwinner_ahci_class_init(ObjectClass
*klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
dc->vmsd = &vmstate_allwinner_ahci;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo allwinner_ahci_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, (continued)
- [Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 03/22] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 04/22] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 05/22] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 06/22] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 07/22] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 09/22] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 08/22] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 10/22] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [PULL 12/22] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 13/22] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 15/22] esp: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 14/22] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 17/22] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 16/22] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 18/22] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 19/22] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 20/22] xen-sysdev: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 21/22] s390-pcibus: No need to set user_creatable=false explicitly, Eduardo Habkost, 2017/05/17