[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/22] esp: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 15/22] esp: Remove user_creatable flag |
Date: |
Wed, 17 May 2017 10:39:56 -0300 |
esp devices aren't going to work with -device, as they need IRQs
to be connected and mmio to be mapped (this is done by
esp_init()). Remove the user_creatable flag from the device
class.
Cc: Marcel Apfelbaum <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/scsi/esp.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index 7bdc1e1b99..eee831efeb 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -728,11 +728,6 @@ static void sysbus_esp_class_init(ObjectClass *klass, void
*data)
dc->reset = sysbus_esp_hard_reset;
dc->vmsd = &vmstate_sysbus_esp_scsi;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo sysbus_esp_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, (continued)
- [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 05/22] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 06/22] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 07/22] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 09/22] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 08/22] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 10/22] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 12/22] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 13/22] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 15/22] esp: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [PULL 14/22] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 17/22] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 16/22] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 18/22] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 19/22] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 20/22] xen-sysdev: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 21/22] s390-pcibus: No need to set user_creatable=false explicitly, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 22/22] tests: Add [+-]feature and feature=on|off test cases, Eduardo Habkost, 2017/05/17
- Re: [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17, Stefan Hajnoczi, 2017/05/17