qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler library
Date: Mon, 2 Oct 2017 14:34:12 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 10/02/2017 09:36 AM, Philippe Mathieu-Daudé wrote:
> Maybe some defines like:
> 
> #define LARGEST_TARGET_INSTR_SIZE 32
> 
> #define MINIMUM_TARGET_PAGE_SIZE 1024

Eh.  If I weren't simply pulling numbers out of my hat, perhaps.
Does it really make things clearer beyond sizeof or a great big comment?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]