[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler |
Date: |
Thu, 19 Oct 2017 11:10:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/19/2017 08:11 AM, Dong Jia Shi wrote:
>> + if (!sch || !css_subch_visible(sch)) {
>> + setcc(cpu, 3);
> ?:
> s/3/IOINST_CC_NOT_OPERATIONAL/
>
> This also applies to other alike cases.
>
I do not know. My first reaction was that I'm against because
were IOInstEnding strongly typed, it would not work as set
cc takes an int and works not just for IO instructions.
OTOH the same goes for setcc(cpu, css_do_xsch(sch)) so that
ain't really an argument, and it would improve grepability.
So I think I'm in favor now.
Halil
- Re: [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair, (continued)
[Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Halil Pasic, 2017/10/17