[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/9] ui: use correct union field for key number
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/9] ui: use correct union field for key number |
Date: |
Mon, 23 Oct 2017 11:19:41 +0200 |
From: "Daniel P. Berrange" <address@hidden>
The code converting key numbers to QKeyCode in the 'input-send-event'
command mistakenly accessed the key->u.qcode union field instead of
the key->u.number field. This is harmless because the fields use the
same size datatype in both cases, but none the less it should be fixed
to avoid confusion.
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/input.c b/ui/input.c
index 290b47354a..4e821f8f2b 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -162,7 +162,7 @@ void qmp_input_send_event(bool has_device, const char
*device,
if (evt->type == INPUT_EVENT_KIND_KEY &&
evt->u.key.data->key->type == KEY_VALUE_KIND_NUMBER) {
KeyValue *key = evt->u.key.data->key;
- QKeyCode code = qemu_input_key_number_to_qcode(key->u.qcode.data);
+ QKeyCode code = qemu_input_key_number_to_qcode(key->u.number.data);
qemu_input_event_send_key_qcode(con, code, evt->u.key.data->down);
} else {
qemu_input_event_send(con, evt);
--
2.9.3
- [Qemu-devel] [PULL 0/9] Input 20171023 patches, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 2/9] ui: fix crash with sendkey and raw key numbers, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 9/9] ui: pull in latest keycodemapdb, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 8/9] ui: normalize the 'sysrq' key into the 'print' key, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 3/9] ui: use correct union field for key number,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 1/9] input: use hex in ps2 keycode trace events, Gerd Hoffmann, 2017/10/23
- Re: [Qemu-devel] [PULL 0/9] Input 20171023 patches, Peter Maydell, 2017/10/25