[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gi
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility |
Date: |
Tue, 24 Oct 2017 19:19:10 +0100 |
Anthony PERARD writes ("Re: [PATCH v5.1 7/8] os-posix: Provide new -runas
<uid>:<gid> facility"):
> On Fri, Oct 20, 2017 at 02:38:21PM +0100, Ian Jackson wrote:
> > +static bool os_parse_runas_uid_gid(const char *optarg)
...
> > + errno = 0;
> > + lv = strtoul(optarg, &ep, 0); /* can't qemu_strtoul, want *ep==':' */
>
> Should strtoul base be 10? If that matter.
If someone wants to write uids in hex then I don't see a reason to
stop them...
> > - if (!user_pwd) {
> > - fprintf(stderr, "User \"%s\" doesn't exist\n", optarg);
> > + if (!user_pwd && !os_parse_runas_uid_gid(optarg)) {
> > + fprintf(stderr,
> > + "User \"%s\" doesn't exist (and is not <uid>.<gid>)\n",
>
> The error message have not been update, I think it should be <uid>:<gid>
Oops.
> With the error message fix:
> Reviewed-by: Anthony PERARD <address@hidden>
Thanks,
Ian.
- [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, (continued)
- [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2017/10/20
- Re: [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable, Stefano Stabellini, 2017/10/26
- [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2017/10/20
- Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all, Stefano Stabellini, 2017/10/26
- Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2017/10/27
- [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2017/10/20
- Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility, Anthony PERARD, 2017/10/24
- Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility,
Ian Jackson <=
- Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility, Stefano Stabellini, 2017/10/26
- Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2017/10/27
- [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2017/10/20
- Re: [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file, Stefano Stabellini, 2017/10/26
- Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore, Stefano Stabellini, 2017/10/26
- Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore, Ian Jackson, 2017/10/27
Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements, no-reply, 2017/10/21