[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variab
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable |
Date: |
Fri, 17 Nov 2017 12:03:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/16/2017 11:38 AM, Cleber Rosa wrote:
> Another legacy variable that did not convince me it has any
> purpose whatsoever.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> +++ b/tests/qemu-iotests/001
> @@ -23,7 +23,6 @@
> seq=`basename $0`
> echo "QA output created by $seq"
>
> -here=`pwd`
Good riddance. And in the majority of the tests, it was a needless
fork(), compared to my preference (which is also guaranteed by POSIX and
by /bin/bash):
> +++ b/tests/qemu-iotests/176
> @@ -27,7 +27,6 @@
> seq="$(basename $0)"
> echo "QA output created by $seq"
>
> -here="$PWD"
since $PWD and `pwd` should always produce the same thing, if we even
had a reason to use it. ;)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks, (continued)
- [Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 08/10] qemu-iotests: clean up double comment characters, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 10/10] qemu-iotests: add section on how to write a new I/O test, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 03/10] qemu-iotests: be strict with expected output, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code), Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 04/10] qemu-iotests: include (source) filters from common.rc, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable, Cleber Rosa, 2017/11/16
- Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable,
Eric Blake <=
- [Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use, Cleber Rosa, 2017/11/16
- [Qemu-devel] [PATCH 06/10] qemu-iotests: turn owner variable into a comment, Cleber Rosa, 2017/11/16