[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot
Date: Mon, 20 Nov 2017 15:36:18 +0100
User-agent: Mutt/1.9.1 (2017-09-22)

Am 17.11.2017 um 19:46 hat Eric Blake geschrieben:
> > -- and I'm not really a fan of testing this on every possible
> > architecture and then adding different reference outputs.
> > 
> > Therefore, the best fix is probably to just filter the hashes out (you
> > don't need the exact value anyway, do you?), and I think it's fine to do
> > this as a follow-up.
> At any rate, I concur with this conclusion; I'll post a followup that
> filters out the hash (for this test, we only care that the existence of
> a hash proves the bitmap exists; unlike 165 where we want to validate
> that it is actually tracking correct information).
> I missed Kevin's -rc2 pull, unless he wants to send a v2; but we also
> have time (it's not the end of the world if the fix goes in -rc3).

There is no rule that a maintainer can only send one pull request per
release candidate. I already missed -rc1, so I wanted to make sure to
get things merged definitely in time for -rc2, but it's not too unlikely
that I'll send another small pull request for tomorrow.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]