qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio con


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages
Date: Mon, 11 Dec 2017 13:59:42 +0000
User-agent: Mutt/1.9.1 (2017-09-22)

On Tue, Dec 05, 2017 at 02:27:18PM +0800, Changpeng Liu wrote:
> @@ -798,6 +801,70 @@ vu_set_slave_req_fd(VuDev *dev, VhostUserMsg *vmsg)
>  }
>  
>  static bool
> +vu_get_config(VuDev *dev, VhostUserMsg *vmsg)
> +{
> +    int ret = -1;
> +
> +    if (dev->iface->get_config) {
> +        ret = dev->iface->get_config(dev, vmsg->payload.config.region,
> +                                     vmsg->payload.config.size);
> +    }
> +
> +    if (ret) {
> +        /* resize to zero to indicate an error to master */
> +        vmsg->size = 0;
> +    }

Please document this error case in vhost-user.txt.  I don't remember
reading about it.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]