[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others |
Date: |
Wed, 31 Jan 2018 08:59:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> System headers should be included with <...>, our own headers with
> "...". Offenders tracked down with an ugly, brittle and probably
> buggy Perl script. Previous iteration was commit a9c94277f0.
>
> Put the cleaned up system header includes first, except for the ones
> the next commit will delete.
>
> While there, separate #include from file comment with a blank line,
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> +++ b/target/i386/hvf/x86_mmu.c
> @@ -15,18 +15,17 @@
> * You should have received a copy of the GNU Lesser General Public
> * License along with this program; if not, see
> <http://www.gnu.org/licenses/>.
> */
> +
> #include "qemu/osdep.h"
> +#include <memory.h>
<memory.h> is an obsolete spelling for the now-universal <string.h>. We
should NEVER need to include it; scripts/clean-includes should be taught
to blacklist this one.
But that's a matter for another patch; this one does exactly what it
promises, and was mechanical (even if the brittle perl script isn't
published), so it's best to keep it as-is.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/19] Clean up includes to reduce compile time, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 10/19] Include qapi/qmp/qobject.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 16/19] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 02/19] Clean up includes, Markus Armbruster, 2018/01/31