[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname() |
Date: |
Mon, 5 Feb 2018 16:18:24 +0100 |
While the basic idea is obvious and could be handled by the default
bdrv_dirname() implementation, we cannot generate a directory name if
the gid or uid are set, so we have to explicitly return NULL in those
cases.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/nfs.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/block/nfs.c b/block/nfs.c
index effc8719b5..ee1160980a 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -874,6 +874,19 @@ static void nfs_refresh_filename(BlockDriverState *bs,
QDict *options)
bs->full_open_options = opts;
}
+static char *nfs_dirname(BlockDriverState *bs, Error **errp)
+{
+ NFSClient *client = bs->opaque;
+
+ if (client->uid || client->gid) {
+ error_setg(errp, "Cannot generate a base directory for NBD node '%s'",
+ bs->filename);
+ return NULL;
+ }
+
+ return g_strdup_printf("nfs://%s%s/", client->server->host, client->path);
+}
+
#ifdef LIBNFS_FEATURE_PAGECACHE
static void nfs_invalidate_cache(BlockDriverState *bs,
Error **errp)
@@ -907,6 +920,7 @@ static BlockDriver bdrv_nfs = {
.bdrv_detach_aio_context = nfs_detach_aio_context,
.bdrv_attach_aio_context = nfs_attach_aio_context,
.bdrv_refresh_filename = nfs_refresh_filename,
+ .bdrv_dirname = nfs_dirname,
#ifdef LIBNFS_FEATURE_PAGECACHE
.bdrv_invalidate_cache = nfs_invalidate_cache,
--
2.14.3
- Re: [Qemu-devel] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename, (continued)
- [Qemu-devel] [PATCH v8 06/26] block: Make path_combine() return the path, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 07/26] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 08/26] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 09/26] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(),
Max Reitz <=
- [Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2018/02/05