[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig" |
Date: |
Fri, 23 Mar 2018 16:11:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/12/2018 08:11 AM, Igor Mammedov wrote:
New option will be used to allow commands, which are prepared/need
to run run in preconfig state. Other commands that should be able
s/run run in/run, during/
to run in preconfig state, should be ammeded to not expect machine
s/ammeded/amended/
in initialized state or deal with it.
For compatibility reasons, commands, that don't use new flag
s/commands,/commands/
'allowed-in-preconfig' explicitly, are not permited to run in
s/explicitly,/explicitly/
s/permited/permitted/
preconfig state but allowed in all other states like they used
to be.
Within this patch allow following commands in preconfig state:
qmp_capabilities
query-qmp-schema
query-commands
query-status
cont
to allow qmp connection, basic introspection and moving to the next
state.
Looks like a reasonable list. Maybe also query-command-line-options
should be here?
PS:
set-numa-node and query-hotpluggable-cpus will be enabled later in
a separate patch.
Signed-off-by: Igor Mammedov <address@hidden>
---
v4:
* replaces complex "universal" approach
"[PATCH v3 5/9] QAPI: allow to specify valid runstates per command"
with a simpler new command flag "allowed-in-preconfig".
(Eric Blake <address@hidden>)
Thanks; it looks a lot more maintainable now. However, you need to
rebase, now that 'allow-oob' has already landed.
+++ b/qapi/introspect.json
@@ -259,12 +259,16 @@
#
# @ret-type: the name of the command's result type.
#
+# @allowed-in-preconfig: command could be executed in preconfig runstate,
s/could/can/
double space before in
+# default: 'false' (Since 2.12)
/me must resist the urge to call out softfreeze ;)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option, (continued)
[Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 8/9] qmp: add set-numa-node command, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 9/9] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 7/9] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 6/9] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/03/12