[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig" |
Date: |
Wed, 28 Mar 2018 17:23:10 +0200 |
On Fri, 23 Mar 2018 16:11:53 -0500
Eric Blake <address@hidden> wrote:
> On 03/12/2018 08:11 AM, Igor Mammedov wrote:
[...]
>
> > preconfig state but allowed in all other states like they used
> > to be.
> >
> > Within this patch allow following commands in preconfig state:
> > qmp_capabilities
> > query-qmp-schema
> > query-commands
> > query-status
> > cont
> > to allow qmp connection, basic introspection and moving to the next
> > state.
>
> Looks like a reasonable list. Maybe also query-command-line-options
> should be here?
added
> >
> > PS:
> > set-numa-node and query-hotpluggable-cpus will be enabled later in
> > a separate patch.
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > v4:
> > * replaces complex "universal" approach
> > "[PATCH v3 5/9] QAPI: allow to specify valid runstates per command"
> > with a simpler new command flag "allowed-in-preconfig".
> > (Eric Blake <address@hidden>)
>
> Thanks; it looks a lot more maintainable now. However, you need to
> rebase, now that 'allow-oob' has already landed.
rebased
[...]
All other comments are addressed as well
[Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 8/9] qmp: add set-numa-node command, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 9/9] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 7/9] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 6/9] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/03/12