[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/67] trace: use local path for local headers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 21/67] trace: use local path for local headers |
Date: |
Fri, 4 May 2018 13:36:29 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Can this be squashed with your 6/67?
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> trace/qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/qmp.c b/trace/qmp.c
> index 756086c..ea99b00 100644
> --- a/trace/qmp.c
> +++ b/trace/qmp.c
> @@ -10,7 +10,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "qapi/qapi-commands-trace.h"
> -#include "trace/control.h"
> +#include "control.h"
>
>
> static CPUState *get_cpu(bool has_vcpu, int vcpu, Error **errp)
>
- [Qemu-devel] [PATCH 17/67] colo: use local path for local headers, (continued)
- [Qemu-devel] [PATCH 17/67] colo: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 19/67] xtensa: relative include for parent directory, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 18/67] qga: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 23/67] slirp: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 20/67] tests: relative include for child directory, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 21/67] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 27/67] replication: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 31/67] target/cris: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor, Michael S. Tsirkin, 2018/05/03