|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() |
Date: | Wed, 16 May 2018 11:49:00 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/16/2018 11:10 AM, Kevin Wolf wrote:
Don't throw away local_err, but propagate it to errp. Signed-off-by: Kevin Wolf <address@hidden> --- block/nfs.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
diff --git a/block/nfs.c b/block/nfs.c index d6364d28bb..3349b67a76 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options, qobject_unref(crumpled);if (local_err) {+ error_propagate(errp, local_err); return NULL; }
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |