[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 02/38] target-microblaze: dec_store: Use bool ins
From: |
Edgar E. Iglesias |
Subject: |
[Qemu-devel] [PATCH v3 02/38] target-microblaze: dec_store: Use bool instead of unsigned int |
Date: |
Wed, 16 May 2018 20:51:10 +0200 |
From: "Edgar E. Iglesias" <address@hidden>
Use bool instead of unsigned int to represent flags.
Also, use extract32 instead of open coding the bit extract.
No functional change.
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>
---
target/microblaze/translate.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index a8a5eaebec..413e683aec 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1027,14 +1027,15 @@ static void dec_store(DisasContext *dc)
{
TCGv t, *addr, swx_addr;
TCGLabel *swx_skip = NULL;
- unsigned int size, rev = 0, ex = 0;
+ unsigned int size;
+ bool rev = false, ex = false;
TCGMemOp mop;
mop = dc->opcode & 3;
size = 1 << mop;
if (!dc->type_b) {
- rev = (dc->ir >> 9) & 1;
- ex = (dc->ir >> 10) & 1;
+ rev = extract32(dc->ir, 9, 1);
+ ex = extract32(dc->ir, 10, 1);
}
mop |= MO_TE;
if (rev) {
--
2.14.1
- [Qemu-devel] [PATCH v3 00/38] target-microblaze: Add support for Extended Addressing, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 02/38] target-microblaze: dec_store: Use bool instead of unsigned int,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH v3 03/38] target-microblaze: compute_ldst_addr: Use bool instead of int, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 01/38] target-microblaze: dec_load: Use bool instead of unsigned int, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 04/38] target-microblaze: Fallback to our latest CPU version, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 05/38] target-microblaze: Correct special register array sizes, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 08/38] target-microblaze: Remove USE_MMU PVR checks, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 06/38] target-microblaze: Correct the PVR array size, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 10/38] target-microblaze: Bypass MMU with MMU_NOMMU_IDX, Edgar E. Iglesias, 2018/05/16