[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize sett
|
From: |
Edgar E. Iglesias |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU |
|
Date: |
Thu, 17 May 2018 20:00:14 +0200 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
On Thu, May 17, 2018 at 10:26:00AM -0700, Richard Henderson wrote:
> On 05/16/2018 11:51 AM, Edgar E. Iglesias wrote:
> > - env->pvr.regs[11] = PVR11_USE_MMU | (16 << 17);
> > + env->pvr.regs[11] = cpu->cfg.use_mmu ? PVR11_USE_MMU : 0 |
> > + 16 << 17;
>
> I believe this needs parenthesis around the ?:.
Goot catch, I've fixed that for v4.
Cheers,
Edgar
- [Qemu-devel] [PATCH v3 00/38] target-microblaze: Add support for Extended Addressing, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 02/38] target-microblaze: dec_store: Use bool instead of unsigned int, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 03/38] target-microblaze: compute_ldst_addr: Use bool instead of int, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 01/38] target-microblaze: dec_load: Use bool instead of unsigned int, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 04/38] target-microblaze: Fallback to our latest CPU version, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 05/38] target-microblaze: Correct special register array sizes, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 08/38] target-microblaze: Remove USE_MMU PVR checks, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 06/38] target-microblaze: Correct the PVR array size, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 10/38] target-microblaze: Bypass MMU with MMU_NOMMU_IDX, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 11/38] target-microblaze: Make compute_ldst_addr always use a temp, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 07/38] target-microblaze: Tighten up TCGv_i32 vs TCGv type usage, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 13/38] target-microblaze: Use TCGv for load/store addresses, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 12/38] target-microblaze: Remove pointer indirection for ld/st addresses, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 14/38] target-microblaze: Name special registers we support, Edgar E. Iglesias, 2018/05/16
- [Qemu-devel] [PATCH v3 15/38] target-microblaze: Break out trap_userspace(), Edgar E. Iglesias, 2018/05/16