[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences |
Date: |
Thu, 31 May 2018 21:22:49 +0200 |
On Thu, 31 May 2018 12:27:35 -0400
Keno Fischer <address@hidden> wrote:
> >> --- a/hw/9pfs/9p-local.c
> >> +++ b/hw/9pfs/9p-local.c
> >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char
> >> *path, int flags,
> >> assert(*path != '/');
> >>
> >> head = g_strdup(path);
> >> - c = strchrnul(path, '/');
> >> + /* equivalent to strchrnul(), but that is not available on Darwin
> >> */
> >
> > Please make a qemu_strchrnul() helper with a separate implementation for
> > Darwin
> > then. I guess you can put it in this file since there aren't any other
> > users in
> > the QEMU code base.
>
> There actually are, but they also use this pattern. Could you
> suggest the best place to put this utility? I can submit a patch
> to switch all instances of this pattern over.
Oh if the pattern is already used in other places, it's probably not
worth the pain... so please forget this :)
- Re: [Qemu-devel] [PATCH 03/13] 9p: Move a couple xattr functions to 9p-util, (continued)
[Qemu-devel] [PATCH 04/13] 9p: darwin: Handle struct stat(fs) differences, keno, 2018/05/26
[Qemu-devel] [PATCH 05/13] 9p: darwin: Handle struct dirent differences, keno, 2018/05/26
[Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences, keno, 2018/05/26
[Qemu-devel] [PATCH 07/13] 9p: darwin: Properly translate AT_REMOVEDIR flag, keno, 2018/05/26
[Qemu-devel] [PATCH 08/13] 9p: darwin: Ignore O_{NOATIME, DIRECT}, keno, 2018/05/26
[Qemu-devel] [PATCH 09/13] 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX, keno, 2018/05/26