[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/35] target/mips: Add nanoMIPS rotx instructio
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 21/35] target/mips: Add nanoMIPS rotx instruction |
Date: |
Sun, 24 Jun 2018 17:30:47 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/20/2018 05:06 AM, Yongbok Kim wrote:
> case NM_P_ROTX:
> + if (rt != 0) {
> + TCGv t0 = tcg_temp_new();
> + TCGv_i32 shift = tcg_const_i32(extract32(ctx->opcode, 0, 5));
> + TCGv_i32 shiftx = tcg_const_i32(extract32(ctx->opcode, 7, 4)
> + << 1);
> + TCGv_i32 stripe = tcg_const_i32((ctx->opcode >> 6) & 1);
> +
> + gen_load_gpr(t0, rs);
> + gen_helper_rotx(cpu_gpr[rt], t0, shift, shiftx, stripe);
> + tcg_temp_free(t0);
> +
> + tcg_temp_free_i32(shift);
> + tcg_temp_free_i32(shiftx);
> + tcg_temp_free_i32(stripe);
> + }
It would be worth your while to recognize the special case of BYTEREVW.
But otherwise
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 15/35] target/mips: Implement nanoMIPS EXTW instruction, (continued)
- [Qemu-devel] [PATCH 15/35] target/mips: Implement nanoMIPS EXTW instruction, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 16/35] target/mips: Add has_isa_mode, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 17/35] target/mips: Add nanoMIPS load store instructions, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 18/35] target/mips: Add nanoMIPS branch instructions, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 19/35] target/mips: Implement nanoMIPS LLWP/SCWP pair, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 20/35] target/mips: Fix not to update BadVAddr in Debug Mode, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 21/35] target/mips: Add nanoMIPS rotx instruction, Yongbok Kim, 2018/06/20
- Re: [Qemu-devel] [PATCH 21/35] target/mips: Add nanoMIPS rotx instruction,
Richard Henderson <=
- [Qemu-devel] [PATCH 22/35] target/mips: Fix data type for offset, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 23/35] target/mips: Update BadInstr{P} regs on nanoMIPS, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 24/35] target/mips: Add nanoMIPS CP0_BadInstrX register, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 25/35] target/mips: Config3.ISAOnExc is read only in nanoMIPS, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 26/35] target/mips: Fix nanoMIPS exception_resume_pc, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 27/35] target/mips: Fix nanoMIPS set_hflags_for_handler, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 28/35] target/mips: Fix nanoMIPS set_pc, Yongbok Kim, 2018/06/20
- [Qemu-devel] [PATCH 29/35] target/mips: Fix ERET/ERETNC can cause ADEL exception, Yongbok Kim, 2018/06/20