[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] hw/mips/boston: don't make flash region 'nomigra
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 2/9] hw/mips/boston: don't make flash region 'nomigrate' |
Date: |
Mon, 25 Jun 2018 22:05:57 +0200 |
From: Peter Maydell <address@hidden>
Currently we use memory_region_init_rom_nomigrate() to create
the "boston.flash" memory region, and we don't manually register
it with vmstate_register_ram(). This currently means that its
contents are migrated but as a ram block whose name is the empty
string; in future it may mean they are not migrated at all. Use
memory_region_init_ram() instead.
Note that this is a a cross-version migration compatibility break
for the "boston" machine.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
---
hw/mips/boston.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 52cce19..14e6f95 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -471,8 +471,7 @@ static void boston_mach_init(MachineState *machine)
sysbus_mmio_map_overlap(SYS_BUS_DEVICE(s->cps), 0, 0, 1);
flash = g_new(MemoryRegion, 1);
- memory_region_init_rom_nomigrate(flash, NULL,
- "boston.flash", 128 * M_BYTE, &err);
+ memory_region_init_rom(flash, NULL, "boston.flash", 128 * M_BYTE, &err);
memory_region_add_subregion_overlap(sys_mem, 0x18000000, flash, 0);
ddr = g_new(MemoryRegion, 1);
--
2.7.4
- [Qemu-devel] [PULL 0/9] Target MIPS queue, 2018-06-25, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 9/9] target/mips: Fix gdbstub to read/write 64 bit FP registers, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 3/9] hw/mips/mips_malta: don't make bios region 'nomigrate', Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 8/9] target/mips: Fix data type for offset, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 5/9] target/mips: Raise a RI when given fs is n/a from CTC1, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 2/9] hw/mips/boston: don't make flash region 'nomigrate',
Aleksandar Markovic <=
- [Qemu-devel] [PULL 4/9] hw/pci-host/xilinx-pcie: don't make "io" region be RAM, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 6/9] target/mips: Fix microMIPS on reset, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 7/9] target/mips: Update gen_flt_ldst(), Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 1/9] MAINTAINERS: update target-mips maintainers, Aleksandar Markovic, 2018/06/25
- Re: [Qemu-devel] [PULL 0/9] Target MIPS queue, 2018-06-25, Peter Maydell, 2018/06/26