Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc

[Stafford Horne]

Hello,

On Wed, Jul 4, 2018, 7:34 AM Philippe Mathieu-Daudé <address@hidden> wrote:

> Hi Stafford,
>
> On 07/02/2018 12:10 PM, Stafford Horne wrote:
> > From: Richard Henderson <address@hidden>
> >
> > All of the existing code was boilerplate from elsewhere,
> > and would crash the guest upon the first signal.
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> > Signed-off-by: Stafford Horne <address@hidden>
> >
> > ---
> > v2:
> >   Add a comment to the new definition of target_pt_regs.
> >   Install the signal mask into the ucontext.
> > v3:
> >   Incorporate feedback from Laurent.
>
> Oops this is not supposed to enter git history, something is wrong with
> your pull request script.
>

Sorry, I brought these in from Richards tree and saw them but thought it
was fine to keep the annotations.

I'll remove them from patches in the future.

Richard, how do you usually remove these before your pr?  I suppose you
have some kind of script?

-stafford




> > ---
> >  linux-user/openrisc/signal.c         | 217 +++++++++++----------------
> >  linux-user/openrisc/target_syscall.h |  28 +---
> >  linux-user/signal.c                  |   2 +-
> >  target/openrisc/cpu.c                |   1 +
> >  4 files changed, 94 insertions(+), 154 deletions(-)
>
> <snip>
>