[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/9] block: Fix dst reading after tail copy o
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/9] block: Fix dst reading after tail copy offloading |
|
Date: |
Thu, 5 Jul 2018 17:57:55 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 05.07.2018 um 09:36 hat Fam Zheng geschrieben:
> Qcow2 allocates new clusters after the end of the file. If it is the
> destinaton
> of copy offloading, we must adjust dst->bs->total_sectors. Otherwise, further
> reads will drop to the "beyond EOF" code path and return zeroes, which problem
> is caught by iotests 222.
>
> Follow the logic in the normal write code and update bs->total_sectors after
> I/O is done.
>
> While at it, add a few convenient trace points to aid future debug experiences
> in the topic.
Apart from the comments I made, this series also conflicts with
Vladimir's "[PATCH v3 0/4] fix image fleecing". Can you please rebase on
top of his series for the next version?
Kevin
- Re: [Qemu-devel] [PATCH v2 6/9] block: Use common req handling for discard, (continued)
[Qemu-devel] [PATCH v2 7/9] block: Use common req handling in copy offloading, Fam Zheng, 2018/07/05
[Qemu-devel] [PATCH v2 8/9] block: Fix bdrv_co_truncate overlap check, Fam Zheng, 2018/07/05
[Qemu-devel] [PATCH v2 9/9] block: Use common write req handling in truncate, Fam Zheng, 2018/07/05
Re: [Qemu-devel] [PATCH v2 0/9] block: Fix dst reading after tail copy offloading,
Kevin Wolf <=