[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 9/9] block: Use common write req handling in

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 9/9] block: Use common write req handling in truncate
Date: Fri, 6 Jul 2018 17:12:18 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/05/2018 02:37 AM, Fam Zheng wrote:
Truncation is the last to convert from open coded req handling to
reusing helpers. This time the permission check in prepare has to adapt
to the new caller: it checks a different permission bit, and don't

did you mean "won't" or "doesn't"?

trigger the before write notifier.

Also, truncation should always trigger a bs->total_sectors update and in
turn call parent resize_cb. Update the condition in finish helper, too.

It's intended to do a duplicated bs->read_only check before calling
bdrv_co_write_req_prepare() so that we can be more informative with the
error message, as bdrv_co_write_req_prepare() doesn't have Error

Signed-off-by: Fam Zheng <address@hidden>
  block/io.c | 54 +++++++++++++++++++++++++++++++++---------------------
  1 file changed, 33 insertions(+), 21 deletions(-)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]